Hi,

> > > Possible values are:
> > >
> > > - php_auth_exposure=user
> > >   Only PHP_AUTH_USER is exposed.
> > >
> > > - php_auth_exposure=pw
> > >   Only PHP_AUTH_PW is exposed
> > >
> > > - php_auth_exposure=user,pw
> > >   Both PHP_AUTH_USER and PHP_AUTH_PW are exposeed
> > 
> > Moriyoshi, have you considered using constants here instead of strings?  For
> > example:
> > 
> > - php_auth_exposure=AUTH_EXPOSE_USER
> >   Only PHP_AUTH_USER is exposed.
> > 
> > - php_auth_exposure=AUTH_EXPOSE_PW
> >   Only PHP_AUTH_PW is exposed
> > 
> > - php_auth_exposure=AUTH_EXPOSE_USER | AUTH_EXPOSE_PW
> >   Both PHP_AUTH_USER and PHP_AUTH_PW are exposeed
> > 
> > It resembles the style used by error reporting, which will be less confusing
> > for novices.

At first I thought of using constants like you mentioned, but I decided to 
not do so in my patch because I don't want to pollute the namespace with 
such trivial constants that are likely to be used only in ini settings.

> There is no difference here, both are strings anyway. And the latest 
> option "AUTH_EXPOSE_USER | AUTH_EXPOSE_PW" wont work in an httpd.conf 
> file. Also, this is NOT the style we have in php.ini. I don't see any 
> valid point to use this thing.

I don't think this entry needs to be able to be toggled in per-dir 
settings.

Moriyoshi

> Derick
> 
> -- 
> 
> -------------------------------------------------------------------------
>  Derick Rethans                                 http://derickrethans.nl/ 
>  PHP Magazine - PHP Magazine for Professionals       http://php-mag.net/
> -------------------------------------------------------------------------
> 


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to