Re: [PHP-DEV] Patch for #21330 - socket_select()

[Tularis]

[EMAIL PROTECTED] wrote:

Well it was attached it looks the mailing list is dening them.

It put it online: http://nicos.worldakt.com/socket_select.patch

Regards.
M.CHAILLAN Nicolas
[EMAIL PROTECTED]
www.WorldAKT.com Hébergement de sites internets.

I know this doesn't really belong here, but,
I always like to keep my code as small as possible, do I think you should change:

if (sec != NULL || sec != 0) {
convert_to_long_ex(&sec);
tv.tv_sec = Z_LVAL_P(sec);
tv.tv_usec = usec;
tv_p = &tv;
}
else {
tv.tv_sec = 0;
tv.tv_usec = 0;
tv_p = &tv;
}

to:

if (sec != NULL || sec != 0) {
convert_to_long_ex(&sec);
tv.tv_sec = Z_LVAL_P(sec);
tv.tv_usec = usec;
} else {
tv.tv_sec = 0;
tv.tv_usec = 0;
}
tv_p = &tv;

But, as I said it's just a fashion statement, and nothing important... let stand that it will make *any* difference ;)


--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php