[PHP-DEV] ext_skel

[Andi Gutmans]

Hi,

Someone seems to have changed ext_skel to create the ZEND_FETCH_RESOURCE() call to be inside an if() statement to check the resource is non-zero, i.e.:
if (myresource) {
ZEND_FETCH_RESOURCE(....);
}

What is the reason this was added? The resource mechanism checks for this automatically and handles relevant errors in a consistent way. I think this if() should be removed.
Also does anyone object to ZEND_FETCH_RESOURCE() being commented. I think it's beneficial for newly generated extensions to be able to compile right away so that ppl can see that their setup, buildconf, config.m4 and so on is OK for development.

Andi


--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php