Well, to me, calling the code that flushes the headers and the output buffers twice doesn't kill us. Unless someone can come up with a better way to not call these two functions in main/main.c::php_request_shutdown, the patch suffices for me. MOD_PHP4_H is undefined in main.c, so it's not acceptable.
Joseph > -----Original Message----- > From: Brian Moon [mailto:[EMAIL PROTECTED]] > Sent: Monday, February 03, 2003 5:30 PM > To: Joseph Tate; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] > Cc: Php-Dev List > Subject: Re: [PHP-DEV] Register Shutdown Function for Apache > > > Hmm, there is #define MOD_PHP4_H in sapi/apache/mod_php4.h. Not real > descriptive, but seems to be unique to the Apache sapi. > > Brian Moon > dealnews.com > > > ----- Original Message ----- > From: "Joseph Tate" <[EMAIL PROTECTED]> > To: "Brian Moon" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; > <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> > Cc: "Php-Dev List" <[EMAIL PROTECTED]> > Sent: Monday, February 03, 2003 3:45 PM > Subject: Re: [PHP-DEV] Register Shutdown Function for Apache > > > | Here is an updated patch which copies a few of the methods from > | main/main.c::php_request_shutdown to > | sapi/apache/sapi_apache.c::apache_php_module_main. This has > flushed both > | the headers and output buffers in my two test scripts. Now I need to > figure > | out a way to make sure these don't get called in > | main/main.c::php_request_shutdown on Apache systems. Any pointers on > this? > | Is there a handy #define that I can use if configure is > called --with-apxs? > | > | Joseph > | > | P.S. The two test scripts are: > | > | <?PHP > | header('Location: http://www.mi-corporation.com'); > | exit(); > | ?> > | > | and > | > | <?PHP > | ob_begin(); > | phpinfo(); > | ?> > | > | > -----Original Message----- > | > From: Brian Moon [mailto:[EMAIL PROTECTED]] > | > Sent: Tuesday, January 28, 2003 5:50 PM > | > To: [EMAIL PROTECTED]; Joseph Tate > | > Cc: Php-Dev List; PHP Group > | > Subject: Re: [PHP-DEV] Re: Register Shutdown Function for Apache > | > > | > > | > Give me a patch and I will tell you. ;) > | > > | > Brian Moon > | > dealnews.com > | > > | > > | > ----- Original Message ----- > | > From: "Zeev Suraski" <[EMAIL PROTECTED]> > | > To: "Joseph Tate" <[EMAIL PROTECTED]> > | > Cc: "Brian Moon" <[EMAIL PROTECTED]>; "Php-Dev List" > | > <[EMAIL PROTECTED]>; "PHP Group" <[EMAIL PROTECTED]> > | > Sent: Tuesday, January 28, 2003 4:03 PM > | > Subject: RE: [PHP-DEV] Re: Register Shutdown Function for Apache > | > > | > > | > | At 19:54 28/01/2003, Joseph Tate wrote: > | > | >Then, could we add a sapi_flush()/ob_flush() call at the end of > | > | >apache_php_module_main after calling the normal > | > register_shutdown_functions? > | > | > | > | Yeah, something along these lines. > | > | > | > | >What else might have problems? > | > | > | > | Might is a powerful word :) > | > | > | > | Zeev > | > | > | > | > | > | > | > > | > > | > -- > | > PHP Development Mailing List <http://www.php.net/> > | > To unsubscribe, visit: http://www.php.net/unsub.php > | > > | > > | > > | > > > -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
