I'd really prefer One Right Way. My personal preference is enforce a blank line, but PSR-2 does not include that requirement either. -- Woody Gilk http://about.me/shadowhand
On Sun, Jul 31, 2016 at 2:19 PM, 'Alexander Makarov' via PHP Framework Interoperability Group <php-fig@googlegroups.com> wrote: > The change is part of > https://github.com/php-fig/fig-standards/commit/50a3d046baa5143546dc95bf5930d3523f56be6a, > made after discussion in a pull request: > https://github.com/php-fig/fig-standards/pull/730#discussion_r57308607 and > getting some stats on current state of things. > > It's about blank like right after <?php: > > <?php > declare(strict_types=1); > > namespace Vendor\Package; > > use Vendor\Package\{ClassA as A, ClassB, ClassC as C}; > use Vendor\Package\Namespace\ClassD as D; > > use function Vendor\Package\{functionA, functionB, functionC}; > use const Vendor\Package\{ConstantA, ConstantB, ConstantC}; > > class Foo extends Bar implements FooInterface > { > > > There are three options: > > - Enforce blank line. It was like that initially. Style matches Laravel, > Symfony and Composer. > - Enforce no blank line. Style matches Yii, Aura, Zend, Slim, Propel, PPI, > Doctrine and CakePHP. > - Do not enforce anything. That's what it is after commit. > > Since both projects enforcing and not enforcing blank line are major, > preliminary decision is not to enforce any particular style i.e. both are > valid. > > It's definitely preliminary and could be decided otherwise based on the > survey to be conducted. Still, it's good to discuss it prior to survey so > I'd like your opinions voiced. > > Thanks! > > -- > You received this message because you are subscribed to the Google Groups > "PHP Framework Interoperability Group" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to php-fig+unsubscr...@googlegroups.com. > To post to this group, send email to php-fig@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/php-fig/9178bfbe-56ae-4223-bfed-06b1b08ccd71%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscr...@googlegroups.com. To post to this group, send email to php-fig@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAGOJM6JcCKzhVe8n8j8Gc546JOx4qrOuNaLCN9edWjDch-McCg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
