On Mon, Sep 12, 2016 at 1:04 AM, Andreas Heigl <andr...@heigl.org> wrote: > I have two things I'd like to mention regarding PSR-13: > > First, for me personally it makes less sense to have a > LinkCollectionInterface that doesn't act like I'D expect a Collection to > work. For me a collection is a set of similar items I can then iterate over. > Whether that's a collection of links, headers, or teapots doesn't matter. So > I'd expect an object implementing a CollectionInterface to be iterable and > to already contain the items in question. The current implementation of the > LinkCollectionInterface though looks more like a CollectorInterface. > Something that collects linkInterfaces and can return a > LinkCollectionInterface. I know it's only a slight difference in wording, > but for me it would make a difference in understanding what happens.
Thanks for this feedback! Until recently, I didn't typically think of collections as requiring iteration, but considering that the terminology has definitely been moving in that direction the last few years (google for "first-class collection", and you'll see fairly consistent definitions!), it may make sense to change the name. I'll discuss with Larry today. > Second, I'm not so happy with the way the relation and the link are bound > together in the LinkInterface. For me it makes more sense to have a single > relation to a given resource. As is explicitly outlined in the meta-document > to the PSR it's perfectly valid to use the linkInterface in such a way I was > asking myself whether it wouldn't enhance ease of usage and implementation > to remove allowing multiple relations in a LinkInterface. It would remove > two methods from the EvolvableLinkInterface and therefore ease > implementations. The idea behind the proposal is to provide interfaces that work with known, existing systems. While many (most?) have a 1:1 relationship between a link and its relation, there *are* several, of which the HTML spec itself is the most important! (The spec indicates that any `rel` attribute can be a "space-separated list" of relationships!). So, while 1:1 would be easiest to model, it would effectively make it impossible to do multi-relationships, which are defined by one of our key specification targets. Thanks for the feedback, and we'll post soon regarding the decision about the collection interface; if we decide to change it, we'll start a new review period. > Am Montag, 15. August 2016 19:22:20 UTC+2 schrieb Matthew Weier O'Phinney: >> >> As coordinator of "PSR-13: Link definition interfaces", I hereby >> officially place the proposal in Review status. Review will end no >> earlier than 17:22 on 29 August 2016. >> >> The specification may be found here: >> >> - https://github.com/php-fig/fig-standards/blob/master/proposed/links.md >> >> with a metadocument covering background and decisions here: >> >> - >> https://github.com/php-fig/fig-standards/blob/master/proposed/links-meta.md >> >> Please take some time to review the proposed standard. >> >> As a reminder, during the review period, we may incorporate minor >> changes, but no substantive changes. If you have a suggestion for a >> substantive change, please open a thread to discuss it, so we can >> determine whether we need to return to Draft status to address the >> change, or whether we will choose to move forward. >> >> Thanks in advance! >> >> -- >> Matthew Weier O'Phinney >> mweiero...@gmail.com >> https://mwop.net/ > > -- > You received this message because you are subscribed to the Google Groups > "PHP Framework Interoperability Group" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to php-fig+unsubscr...@googlegroups.com. > To post to this group, send email to php-fig@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/php-fig/c0ba8212-74f9-409f-9735-2d8130a0ce16%40googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- Matthew Weier O'Phinney mweierophin...@gmail.com https://mwop.net/ -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscr...@googlegroups.com. To post to this group, send email to php-fig@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAJp_myW%3DoVM%2BNvZxiGTKpfgdHujjsG6%2B5Tcq0a1NYGLs10WWkA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
