Hi Larry, I did a review of the PR and it looks good. +1 for me.
Regards, Enrico Zimuel Il giorno dom 21 feb 2021 alle ore 20:53 Larry Garfield < la...@garfieldtech.com> ha scritto: > On Sun, Feb 14, 2021, at 1:25 PM, Larry Garfield wrote: > > Michael Babker on Twitter recently alerted me to a bug in the new > > PSR-13 release. Specifically, it typed withAttribute(string $name, > > string $value), which is what the docblock had, but the spec said more > > than just strings were allowed for $value. In particular, arrays and > > bool are called out specifically. This is an API break. > > > > After discussing with implementers (mainly Symfony) to verify existing > > behavior, I offer this second errata with fixes to the spec. > > > > https://github.com/php-fig/fig-standards/pull/1222 > > > > The PR there includes links to the package updates. > > > > As an errata this would require another Core Committee vote, which I > > will call in two weeks unless there are any objections before then, or > > if enough of the CC says to just go ahead and vote sooner. (The two > > week discussion period is encouraged but not strictly required, so I'm > > willing to save time if everyone else is.) > > > > Also, please check and make sure there were no other issues introduced > > that we missed. I'd hate to have to have another bug fix release. :-( > > > > -- > > Larry Garfield > > la...@garfieldtech.com > > Core Committee members, any feedback here? Good, bad, or otherwise? > > --Larry Garfield > > -- > You received this message because you are subscribed to the Google Groups > "PHP Framework Interoperability Group" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to php-fig+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/php-fig/a6824371-d0be-4ea5-8da2-7c1af4bc9c12%40www.fastmail.com > . > -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAOMtwbTjVHGOaNv%3DVvt6B5fawdQWJkhEO2cog6SC6ozNCqmEXw%40mail.gmail.com.
