This is NOT good coding practice, ONLY return something from a function / method if it needs to, otherwise you may get a performance hit.
regards Jonathan -----Original Message----- From: Mark Cubitt [mailto:[EMAIL PROTECTED] Sent: 12 January 2004 17:06 To: Shawn McKenzie; [EMAIL PROTECTED] Subject: RE: [PHP] Function returns Shawn McKenzie wrote: > Maybe a dumb question, but as good coding practice, should all functions > return something even if they don't need to??? > > Example: > > function do_it() > { > echo "hi"; > } > > --or-- > > function do_it() > { > return echo "hi"; > } > > Also, if they do other things but really don't return anything, should they > return true maybe??? I don't think there is a right or wrong way but personally I would do it like this: function do_it() { echo "hi" || return 0; return 1; } -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php