php-i18n Digest 5 Jun 2006 20:48:10 -0000 Issue 329
Topics (messages 1007 through 1010):
Re: Question on zend_make_printable
1007 by: Michael Wallner
1008 by: Marcus Boerger
1009 by: Marcus Boerger
1010 by: Andrei Zmievski
Administrivia:
To subscribe to the digest, e-mail:
[EMAIL PROTECTED]
To unsubscribe from the digest, e-mail:
[EMAIL PROTECTED]
To post to the list, e-mail:
[email protected]
----------------------------------------------------------------------
--- Begin Message ---
Marcus Boerger wrote:
Hello Anrei,
why don't we simply make zend_make_printable_zval() call on of
zend_make_unicode_zval/zend_make_string_zval() depending on ini
setting unicode_semantics, see attached patch.
Probably, because make_printable_zval uses output_encoding?
Regards,
--
Michael
--- End Message ---
--- Begin Message ---
Hello Michael,
in that case i see two options. First provide a third version that
choses between unicode/string automatically which is the reight way
of a lot of stuff internally and stay with the old stuuf. And second
apply the output encoding at the end of the function. Thinking about
it the first solution makes much more sense.
best regards
marcus
Saturday, June 3, 2006, 1:50:26 PM, you wrote:
> Marcus Boerger wrote:
>> Hello Anrei,
>>
>> why don't we simply make zend_make_printable_zval() call on of
>> zend_make_unicode_zval/zend_make_string_zval() depending on ini
>> setting unicode_semantics, see attached patch.
> Probably, because make_printable_zval uses output_encoding?
> Regards,
> --
> Michael
--
Best regards,
marcus
--- End Message ---
--- Begin Message ---
Hello guys,
the first option is of cause kind of easy:
ZEND_API void zend_make_text_zval(zval *expr, zval *expr_copy, int *use_copy)
{
if (UG(unicode)) {
zend_make_unicode_zval(expr, expr_copy, use_copy);
} else {
zend_make_string_zval(expr, expr_copy, use_copy);
}
}
best regards
marcus
Saturday, June 3, 2006, 1:58:36 PM, you wrote:
> Hello Michael,
> in that case i see two options. First provide a third version that
> choses between unicode/string automatically which is the reight way
> of a lot of stuff internally and stay with the old stuuf. And second
> apply the output encoding at the end of the function. Thinking about
> it the first solution makes much more sense.
> best regards
> marcus
> Saturday, June 3, 2006, 1:50:26 PM, you wrote:
>> Marcus Boerger wrote:
>>> Hello Anrei,
>>>
>>> why don't we simply make zend_make_printable_zval() call on of
>>> zend_make_unicode_zval/zend_make_string_zval() depending on ini
>>> setting unicode_semantics, see attached patch.
>> Probably, because make_printable_zval uses output_encoding?
--- End Message ---
--- Begin Message ---
Because the semantics of these functions are different?
zend_make_unicode_zval() and zend_make_string_zval() don't depend on
output_encoding.
-Andrei
On Jun 3, 2006, at 4:47 AM, Marcus Boerger wrote:
Hello Anrei,
why don't we simply make zend_make_printable_zval() call on of
zend_make_unicode_zval/zend_make_string_zval() depending on ini
setting unicode_semantics, see attached patch.
--
Best regards,
Marcus
mailto:[EMAIL PROTECTED]<ze2-make_printabe-20060603.diff.txt>
--- End Message ---
