Awesome, I was waiting to hear from anyone else on qa as well, since there has been no other response I am going to assume that it is acceptable.
From: Nathan Nobbe [mailto:quickshif...@gmail.com] Sent: Sunday, October 14, 2012 11:21 AM To: Clint Priest Cc: php-qa@lists.php.net Subject: Re: [PHP-QA] Tests for new accessors I think it makes perfect sense, Clint, and would love to hear what others have to say. I've often built 'test libraries' or code that is shared among a set of unit tests. No point in duplicating code just because you're writing tests IMO. -nathan On Sun, Oct 14, 2012 at 4:39 AM, Clint Priest <cpri...@zerocue.com<mailto:cpri...@zerocue.com>> wrote: Would it be frowned upon to use include(); within a set of tests to include base code against which multiple tests can be run? I've got around 80 tests now and a change to the RFC is going to require probably 100% of them to have some change. In addition, there are variations of the same test (each of which will fatal error) and they can all use the same "base class." What do you think? Thanks, -Clint
