On Fri, May 2, 2014 at 6:17 AM, Jan Ehrhardt <php...@ehrhardt.nl> wrote: > Ferenc Kovacs in php.qa (Fri, 2 May 2014 12:42:55 +0200): >>> ext\apcu\apc_bin.c(238) : error C2065: 'IS_CONSTANT_ARRAY' : undeclared >>> identifier >> >>Afair this was mentioned in UPGRADING.INTERNALS, if I remember wrong please >>open a bugreport. > > Might be that it is mentioned there (did not check yet), but to an > innocent bystander it looks like a BC break between beta1 and beta2. >
l. Removal of IS_CONSTANT_ARRAY and IS_CONSTANT_INDEX hack These two #defines disappeared. Instead we have now IS_CONSTANT_AST which covers also the functionality IS_CONSTANT_ARRAY bid and furthermore the hack for marking zvals as constant index with IS_CONSTANT_INDEX is now superfluous and so removed. Please note that IS_CONSTANT_AST now has the same value than IS_CONSTANT_ARRAY had. Could someone be.. like just a tiny littlebit more professional then to shit over other people work in the upgrading notes? This is not the place for to show off how much better you are then everyone else. And why does it have to be renamed anyway? It has the same value. Does the same thing. It just got renamed to piss over people? -Hannes -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
