On Jul 25, 2014 11:43 AM, "Ferenc Kovacs" <tyr...@gmail.com> wrote: > > > > > On Fri, Jul 25, 2014 at 4:35 PM, Rogerio Prado de Jesus > <rogeriopra...@gmail.com> wrote: >> >> Hi, Ferenc, >> >> The event ran good (feedbacks in https://joind.in/event/view/2258) and >> probably we will do periodic test fest here in São Paulo, Brazil >> (https://github.com/PHPSP/hexagon-project/issues/14). >> >> Anyway, now you are closing the event by send the Pull Requests to >> https://github.com/php/php-src. >> >> I've a question, please help us: >> >> >> We have some test contributions that targets not only PHP-5.6, but >> PHP-5.5 and master as well. >> >> For every pull request to PHPSP fork, we are going to create three >> branches in (eg. phpsp-pr000-php-5.5, phpsp-pr000-php-5.6 and >> phpsp-pr000-master), and eventually send three pull requests to core >> from PHPSP fork. >> >> # Example: >> >> ## Contributed tests: >> >> https://github.com/PHPSP/php-src/pull/2. >> >> ## Branches created in PHPSP fork: >> >> - https://github.com/PHPSP/php-src/tree/phpsp-pr002-php-5.6 >> - https://github.com/PHPSP/php-src/tree/phpsp-pr002-PHP-5.5 >> - https://github.com/PHPSP/php-src/tree/phpsp-pr002-master >> >> ## Pull requests from PHPSP fork to php/php-src core: >> >> - https://github.com/php/php-src/pull/742 (5.5) >> - https://github.com/php/php-src/pull/743 (5.6) >> - https://github.com/php/php-src/pull/744 (master) >> >> Is that correct? Can I continue with the other contributions we have? >> Or you guys suggest a better path? >> >> Thanks in advance! >> >> Rogerio >> rogeriopra...@php.net >> rogeriopra...@gmail.com >> rogeriopradoj.com >> > > Hi Rogerio, > > we usually merge everything upwards, so if your test is basically the same > across the branches, you should only create a pull request for the lowest > branch applicable, and the one doing the merge will merge up to the higher > branches anyways. > how did the event go? > to tell you the truth I've expected more questions/problems as our test > framework is pretty "unique". :P > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu
1. Hi, Ferenc, thanks for the info, the next prs I'll do this way. 2. The event was really good, we got about 20 contributors in person that day, and our sponsors were awesome: Google (Alê Borba) letting us using their amazing space, and with JetBrains/PHPStorm, paying our lunch, ;-). It was a complete work day, 9 to 6!!! 2.1 A big part of the questions were solved there, again we have to thank a lot the participants and people that helped with the organization. 2.2 Ivan Rosolen, give us a talk about PHPT and how to start. Anderson "Duodraco" guided us on how to compile and pass through some errors with Bison. I set a Vagrantfile in order to provide a minimal env for the job. Paulo Rezende fixing a bunch of my mess :-)... 2.3 Moreover, all the attendees have worked as a real community, helping each other with all and all! I afraid of forgetting some names, so I'll stop by here, Heheh. 2.4 The last part occurred at InterCon PHP Conference, where we got a room for communities (Meetup Community Room) besides the main auditory. There we met many people interested 3. Anyway, as I said, our UG, PHPSP, are planing to make periodically test fests, maybe every 2 or 3 months, running like this: - opening session (in person or online via Google Hangouts) - a period just online watching the pull requests coming to our PHPSP fork, and letting the discussion happen via GitHub issues - a closing session, in order to send the pull requests from fork to official. 3.1 The biggest missing point for us still the lack of not knowing if the coverage got better or not after our tests (LCOV/GCOV). Two contributors got involved on this, Pedro Manoel and Dan Jesus (https://gist.github.com/rogeriopradoj/68f4372483814cba62d5#comment-1258297) (https://github.com/PHPSP/hexagon-project/issues/14#issuecomment-49623830), and perhaps for next test fests we could have this as well. 3.2 If you could point us to something very clear on how to do this, would be awesome! Maybe something that could give just the delta between before and after a new set of tests, you know? - Oh, I said a lot! Thanks for supporting us on this! I hope you could talk constantly from now! -- Rogerio Prado de Jesus rogeriopra...@php.net rogeriopra...@gmail.com rogeriopradoj.com ᐧ -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
