Edit report at https://bugs.php.net/bug.php?id=62055&edit=1
ID: 62055 Updated by: ka...@php.net Reported by: z...@php.net -Summary: Minor fix to ext/zlib/tests/bug60761.phpt +Summary: Make run-tests.php support --CGI-- sections Status: Assigned Type: Bug Package: Testing related Operating System: Any PHP Version: master-Git-2012-05-17 (Git) -Assigned To: zoe +Assigned To: cmb Block user comment: N Private report: N New Comment: @christoph, I think you should apply the patch, server-tests.php is dead anyway and sapi/cli and sapi/cgi is fairly close enough for run-tests.php to just being able to switch anyway Previous Comments: ------------------------------------------------------------------------ [2015-07-18 13:49:13] c...@php.net According to the test file layout documentation[1] the CGI section is supposed to mark tests that must be run as CGI, but it is not implemented for run-tests.php yet. Wouldn't it make sense to implement it? Applying the attached patch "run-tests-cgi" seems to be sufficient. [1] <https://qa.php.net/phpt_details.php#cgi_section> ------------------------------------------------------------------------ [2015-07-18 13:48:29] c...@php.net The following patch has been added/updated: Patch Name: run-tests-cgi Revision: 1437227309 URL: https://bugs.php.net/patch-display.php?bug=62055&patch=run-tests-cgi&revision=1437227309 ------------------------------------------------------------------------ [2012-10-02 13:42:23] z...@php.net This test is not using the CGI. It is just being run by the CLI. The options are 1. to remove the --CGI-- section (which is simply ignored) and the comments and leave it as a valid CLI test. 2. To remove the test ------------------------------------------------------------------------ [2012-05-18 08:43:01] z...@php.net My bad. --CGI-- is a valid test section but only for tests run using server- tests.php. run-tests.php just ignores it silently and uses the php-cli. Would --GZIP_POST-- be helpful? This will use php-cgi... ------------------------------------------------------------------------ [2012-05-17 19:22:37] z...@php.net Description: ------------ ext/zlib/tests/bug60761.phpt Contains a section --CGI-- which is not a PHPT section. The run-tests.php code simply ignores this section. I'm tempted to just remove it, as it makes no difference to the test. However the comments in the test imply that the author intended to run this using php-cgi. It is actually using that cli. It's a valid test (if you take the --CGI-- out), is it useful in relation to bug 60761? ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=62055&edit=1 -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
