Edit report at https://bugs.php.net/bug.php?id=76723&edit=1
ID: 76723 Updated by: nlop...@php.net Reported by: carusogabr...@php.net Summary: Zip extension tests aren't being running in GCOV -Status: Verified +Status: Closed Type: Bug Package: Testing related PHP Version: Irrelevant Assigned To: nlopess Block user comment: N Private report: N New Comment: Done: enabled for PHP 7.3 & HEAD, where it was disabled. Thanks for the heads up! Will pick up the new configs on the next build. Previous Comments: ------------------------------------------------------------------------ [2018-08-09 11:04:23] c...@php.net The actual configuration doesn't appear to be part of the repo[1], so likely has to be changed on the box directly. It might be sensible to add `--enable-zip --without-libzip` to force using the bundled libzip. Nuno, could you please have a look at this? [1] <http://git.php.net/?p=web/gcov.git;a=summary> ------------------------------------------------------------------------ [2018-08-09 00:52:55] carusogabr...@php.net Description: ------------ Recently, during some tests clean up, I've fixed some SKIPIF sections in our tests, and due to this work (http://gcov.php.net/viewer.php?version=PHP_HEAD&func=skip&file=ext%2Ffileinfo%2Ftests%2Ffinfo_file_stream_001.phpt), I noticed that we aren't running our Zip extension tests in GCOV. The `--enable-zip` flag is missing during our configuration: http://gcov.php.net/viewer.php?version=PHP_HEAD&func=system. Is there a specific reason why we don't run them there? In contrast, we do run them in our CIs, Travis (http://git.php.net/?p=php-src.git;a=blob;f=travis/compile.sh;hb=HEAD#l47) for example. I've already reported to internals@ (http://news.php.net/php.internals/103053), but I believe here at bugs.php.net is a better place to discuss and track this issue. Thanks ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=76723&edit=1 -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
