Edit report at https://bugs.php.net/bug.php?id=79913&edit=1
ID: 79913 Updated by: beber...@php.net Reported by: santi at mola dot io Summary: use exec in sh files generated by run-test.php -Status: Open +Status: Closed Type: Feature/Change Request Package: Testing related Operating System: Linux PHP Version: Irrelevant -Assigned To: +Assigned To: beberlei Block user comment: N Private report: N New Comment: Hey Santi, thank you for your contribution, but run-tests.php in master is changed already to allow running "some-test.sh gdb" to directly go into GDB. It is a different approach, but arrives at the same result. As this is a new feature, your PR will not get merged into 7.3 or 7.4 both receiving only bugfixes. I am therefore closing this issue. Previous Comments: ------------------------------------------------------------------------ [2020-07-29 22:28:14] santi at mola dot io The following pull request has been associated: Patch Name: Fix #79913: add exec to run-tests.php's sh files On GitHub: https://github.com/php/php-src/pull/5909 Patch: https://github.com/php/php-src/pull/5909.patch ------------------------------------------------------------------------ [2020-07-29 22:25:34] santi at mola dot io Description: ------------ I often use gdb to debug a failed phpt tests, usually by editing the generated .sh file and prepending "gdb --args" to the command. It is also possible to run gdb directly on the .sh file (setting follow-fork-mode child) but it is less convenient, and also problematic if the test itself forks. This can be solved by just running the test command with "exec". AFAIK this should be inocuous for regular test running, but quite convenient when running gdb. Test script: --------------- gdb --args bash tests/failing_tests.phpt Expected result: ---------------- gdb running normally Actual result: -------------- gdb debugging the parent bash process instead (by default) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=79913&edit=1
