Commit: 38eb30b7ca8c7ac13d3ba9606266ef9500dac2bc
Author: Sobak <msobaczew...@gmail.com> Mon, 23 Jan 2017 16:31:51
+0100
Parents: 0a834ca90dfd2bb864ccf8c6d704cb4c830c4d50
Branches: redesign
Link:
http://git.php.net/?p=web/bugs.git;a=commitdiff;h=38eb30b7ca8c7ac13d3ba9606266ef9500dac2bc
Log:
Minor adjustments for simpler pages like "How to report" or "Search howto"
Changed paths:
M www/assets/css/style.css
A www/assets/images/backtrace-images-win32/analyze.jpg
A www/assets/images/backtrace-images-win32/backtrace.jpg
A www/assets/images/backtrace-images-win32/dbg_options.png
A www/assets/images/backtrace-images-win32/dbg_select_php.png
A www/assets/images/backtrace-images-win32/dbg_wizard_1.png
A www/assets/images/backtrace-images-win32/dbg_wizard_2.png
A www/assets/images/backtrace-images-win32/rules.jpg
M www/bugs-generating-backtrace-win32.php
M www/bugs-generating-backtrace.php
M www/bugs-getting-valgrind-log.php
D www/images/backtrace-images-win32/analyze.jpg
D www/images/backtrace-images-win32/backtrace.jpg
D www/images/backtrace-images-win32/dbg_options.png
D www/images/backtrace-images-win32/dbg_select_php.png
D www/images/backtrace-images-win32/dbg_wizard_1.png
D www/images/backtrace-images-win32/dbg_wizard_2.png
D www/images/backtrace-images-win32/rules.jpg
M www/quick-fix-desc.php
M www/search-howto.php
diff --git a/www/assets/css/style.css b/www/assets/css/style.css
index 647d843..6846244 100644
--- a/www/assets/css/style.css
+++ b/www/assets/css/style.css
@@ -342,7 +342,7 @@ p {
margin:0 0 1.5rem
}
ul, ol {
- margin:0 0 1.5rem 1.5rem;
+ margin:0 0 0.75rem 1.5rem;
padding:0;
}
p:empty {
@@ -1206,7 +1206,8 @@ table.search-bugs tr.sus:hover td {
text-align: right;
}
-.report .text {
+.report .text,
+pre.code-box {
background-color: #FFF;
box-shadow: inset 0 0 0 1px rgba(0,0,0,.15);
border-radius: 0 0 2px 2px;
diff --git a/www/assets/images/backtrace-images-win32/analyze.jpg
b/www/assets/images/backtrace-images-win32/analyze.jpg
new file mode 100644
index 0000000..8fc4baa
Binary files /dev/null and
b/www/assets/images/backtrace-images-win32/analyze.jpg differ
diff --git a/www/assets/images/backtrace-images-win32/backtrace.jpg
b/www/assets/images/backtrace-images-win32/backtrace.jpg
new file mode 100644
index 0000000..2fe5bf2
Binary files /dev/null and
b/www/assets/images/backtrace-images-win32/backtrace.jpg differ
diff --git a/www/assets/images/backtrace-images-win32/dbg_options.png
b/www/assets/images/backtrace-images-win32/dbg_options.png
new file mode 100644
index 0000000..f0a0d61
Binary files /dev/null and
b/www/assets/images/backtrace-images-win32/dbg_options.png differ
diff --git a/www/assets/images/backtrace-images-win32/dbg_select_php.png
b/www/assets/images/backtrace-images-win32/dbg_select_php.png
new file mode 100644
index 0000000..1a37a89
Binary files /dev/null and
b/www/assets/images/backtrace-images-win32/dbg_select_php.png differ
diff --git a/www/assets/images/backtrace-images-win32/dbg_wizard_1.png
b/www/assets/images/backtrace-images-win32/dbg_wizard_1.png
new file mode 100644
index 0000000..6ef5517
Binary files /dev/null and
b/www/assets/images/backtrace-images-win32/dbg_wizard_1.png differ
diff --git a/www/assets/images/backtrace-images-win32/dbg_wizard_2.png
b/www/assets/images/backtrace-images-win32/dbg_wizard_2.png
new file mode 100644
index 0000000..74cf4c9
Binary files /dev/null and
b/www/assets/images/backtrace-images-win32/dbg_wizard_2.png differ
diff --git a/www/assets/images/backtrace-images-win32/rules.jpg
b/www/assets/images/backtrace-images-win32/rules.jpg
new file mode 100644
index 0000000..1c60ae9
Binary files /dev/null and b/www/assets/images/backtrace-images-win32/rules.jpg
differ
diff --git a/www/bugs-generating-backtrace-win32.php
b/www/bugs-generating-backtrace-win32.php
index 852ff8d..5f08824 100644
--- a/www/bugs-generating-backtrace-win32.php
+++ b/www/bugs-generating-backtrace-win32.php
@@ -22,7 +22,7 @@ up in <em>Debug View</em>. If you don't already see the call
stack, go into the
<em>View</em> menu and choose <em>Debug Windows</em> → <em>Call
Stack</em>.</p>
<p>You'll now see something similar to the following lines, this is the
backtrace:</p>
-<pre><code>
+<pre class="code-box">
_efree(void * 0x00000000) line 286 + 3 bytes
zif_http_test(int 0, _zval_struct * 0x007bc3b0, _zval_struct * * 0x00000000,
_zval_struct * 0x00000000, int 0, void * * * 0x00792cd0) line 1685 + 8 bytes
zend_do_fcall_common_helper_SPEC(_zend_execute_data * 0x0012fd6c, void * * *
0x00792cd0) line 188 + 95 bytes
@@ -33,7 +33,7 @@ zend_eval_string_ex(char * 0x00793bce, _zval_struct *
0x00000000, char * 0x00404
main(int 3, char * * 0x00793ba8) line 1078 + 23 bytes
PHP! mainCRTStartup + 227 bytes
KERNEL32! 77e81af6()
-</code></pre>
+</pre>
<!--
Everything below is stolen from Pierre,
@@ -57,33 +57,33 @@ first step is to configure the diagnostic tools. Select the
tools menu and click on "Options and settings". The first tab contains
the path to the symbols files, add the "debug folder" to the existing
list using the "browse" button:</p>
-<p><img src="/images/backtrace-images-win32/dbg_options.png" alt="Options"></p>
+<p><img src="/assets/images/backtrace-images-win32/dbg_options.png"
alt="Options"></p>
<p>Now we are ready to generate our backtrace.</p>
<p>We will use the wizard, click the "Add a rule" button and choose "Crash" as
the rule type:</p>
-<p><img src="/images/backtrace-images-win32/dbg_wizard_1.png" alt="Wizard
#1"></p>
+<p><img src="/assets/images/backtrace-images-win32/dbg_wizard_1.png"
alt="Wizard #1"></p>
<p>In the next window, select "a specific process":</p>
-<p><img src="/images/backtrace-images-win32/dbg_wizard_2.png" alt="Wizard
#2"></p>
+<p><img src="/assets/images/backtrace-images-win32/dbg_wizard_2.png"
alt="Wizard #2"></p>
<p>Add a "sleep(10);" for the first run (from the cmd: "php.exe
crashme.php"), it will let you enough time to click "next" and select
the php process. I you are debugging the Apache module, start Apache with -X
option and choose
httpd.exe instead of php.exe from the process list.
Then proceed further:</p>
-<p><img src="/images/backtrace-images-win32/dbg_select_php.png" alt="Select
the php process"></p>
+<p><img src="/assets/images/backtrace-images-win32/dbg_select_php.png"
alt="Select the php process"></p>
<p>Click again next and let it crash. If everything went well, you should see
your new rule as shown in the image below:</p>
-<p><img src="/images/backtrace-images-win32/rules.jpg" alt="rules list"></p>
+<p><img src="/assets/images/backtrace-images-win32/rules.jpg" alt="rules
list"></p>
<p>It also detected that "php.exe" was used. A rule has been created
for all instance of "php.exe". It will save you the sleep and process
selection.</p>
<p>Now you can click the "Analyze data" button:</p>
-<p><img src="/images/backtrace-images-win32/analyze.jpg" alt="Analyze"></p>
+<p><img src="/assets/images/backtrace-images-win32/analyze.jpg"
alt="Analyze"></p>
<p>Et voila, the complete report will show up in your internet explorer
(compressed html):</p>
-<p><img src="/images/backtrace-images-win32/backtrace.jpg" alt="Debug report
backtrace screenshot"></a></p>
+<p><img src="/assets/images/backtrace-images-win32/backtrace.jpg" alt="Debug
report backtrace screenshot"></a></p>
<p>What we need is the backtrace itself which can be found under "Thread X -
System ID XXX".</p>
diff --git a/www/bugs-generating-backtrace.php
b/www/bugs-generating-backtrace.php
index 69c3129..bdcc803 100644
--- a/www/bugs-generating-backtrace.php
+++ b/www/bugs-generating-backtrace.php
@@ -7,18 +7,18 @@ response_header('Generating a gdb backtrace');
<h3>Noticing PHP crashes</h3>
-There's no absolute way to know that PHP is crashing, but there may
+<p>There's no absolute way to know that PHP is crashing, but there may
be signs. Typically, if you access a page that is always supposed
to generate output (has a leading HTML block, for example), and
suddenly get "Document contains no data" from your browser, it may
mean that PHP crashes somewhere along the execution of the script.
Another way to tell that PHP is crashing is by looking at the Apache
error logs, and looking for SEGV (Apache 1.2) or Segmentation
-Fault (Apache 1.3).
+Fault (Apache 1.3).</p>
<h3>Important!</h3>
-To get a backtrace with correct information you must have
-PHP configured with <code>--enable-debug</code>!
+<p>To get a backtrace with correct information you must have
+PHP configured with <code>--enable-debug</code>!</p>
<h3>If you don't have a core file yet:</h3>
@@ -138,7 +138,7 @@ be used as a guideline on how to handle your segfault.</p>
<ul>
<li>Sample gdb session</li>
- <pre><code>
+ <pre class="code-box">
(gdb) bt
#0 0x080ca21b in _efree (ptr=0xbfffdb9b) at zend_alloc.c:240
#1 0x080d691a in _zval_dtor (zvalue=0x8186b94) at zend_variables.c:44
@@ -162,7 +162,7 @@ $15 = 0x816cfc4 "result_error"
(gdb) print (char *)executor_globals.active_op_array->filename
$16 = 0x816afbc "/home/yohgaki/php/DEV/segfault.php"
(gdb)
- </code></pre>
+ </pre>
</ul>
<p>In this session, frame 3 is the last <b><code>execute()</code></b>
diff --git a/www/bugs-getting-valgrind-log.php
b/www/bugs-getting-valgrind-log.php
index 71fd706..8ee0cf2 100644
--- a/www/bugs-getting-valgrind-log.php
+++ b/www/bugs-getting-valgrind-log.php
@@ -5,10 +5,10 @@ response_header('Generating a valgrind log');
<h1>Generating a valgrind log</h1>
-<h3>Important!</h3>
-To get a meaningful log you must have
-PHP configured with <code>--enable-debug</code>
-and disable Zend memory manager.
+<p class="warn">
+ To get a meaningful log you must have PHP configured with
<code>--enable-debug</code>
+ and disable Zend memory manager.
+</p>
<h3>Disabling Zend MM</h3>
@@ -21,8 +21,8 @@ and disable Zend memory manager.
</p>
<p>
Use
- <pre><code>export USE_ZEND_ALLOC=0</code></pre> or
- <pre><code>setenv USE_ZEND_ALLOC 0</code></pre> (the syntax depends on
+ <pre class="code-box">export USE_ZEND_ALLOC=0<</pre> or
+ <pre class="code-box">setenv USE_ZEND_ALLOC 0</pre> (the syntax depends on
what your shell supports).
</p>
<p>
@@ -35,8 +35,8 @@ and disable Zend memory manager.
<p>
To correctly show the stack frames for extensions compiled as shared
libraries, set:
- <pre><code>export ZEND_DONT_UNLOAD_MODULES=1</code></pre> or
- <pre><code>setenv ZEND_DONT_UNLOAD_MODULES 1</code></pre> (the syntax depends
on
+ <pre class="code-box">export ZEND_DONT_UNLOAD_MODULES=1</pre> or
+ <pre class="code-box">setenv ZEND_DONT_UNLOAD_MODULES 1</pre> (the syntax
depends on
what your shell supports).
</p>
@@ -51,10 +51,8 @@ and disable Zend memory manager.
you need to execute the following command:
</p>
-<pre>
- <code>
+<pre class="code-box">
valgrind --tool=memcheck --num-callers=30 --log-file=php.log /path/to/php-cli
script.php
- </code>
</pre>
<p>
@@ -75,11 +73,9 @@ and disable Zend memory manager.
the required debug info. To check it, run <code>file /path/to/httpd</code>,
it should output something like this (notice "not stripped"):
</p>
-<pre>
- <code>
+<pre class="code-box">
# file /usr/local/apache2/bin/httpd
/usr/local/apache2/bin/httpd: ELF 64-bit LSB executable, x86-64, version 1
(SYSV), for GNU/Linux 2.6.4, dynamically linked (uses shared libs), not stripped
- </code>
</pre>
<p>
@@ -87,10 +83,8 @@ and disable Zend memory manager.
you need to run the Apache itself under valgrind:
</p>
-<pre>
- <code>
+<pre class="code-box">
valgrind --tool=memcheck --num-callers=30 --log-file=apache.log
/usr/local/apache/bin/httpd -X
- </code>
</pre>
<p>
diff --git a/www/images/backtrace-images-win32/analyze.jpg
b/www/images/backtrace-images-win32/analyze.jpg
deleted file mode 100644
index 8fc4baa..0000000
Binary files a/www/images/backtrace-images-win32/analyze.jpg and /dev/null
differ
diff --git a/www/images/backtrace-images-win32/backtrace.jpg
b/www/images/backtrace-images-win32/backtrace.jpg
deleted file mode 100644
index 2fe5bf2..0000000
Binary files a/www/images/backtrace-images-win32/backtrace.jpg and /dev/null
differ
diff --git a/www/images/backtrace-images-win32/dbg_options.png
b/www/images/backtrace-images-win32/dbg_options.png
deleted file mode 100644
index f0a0d61..0000000
Binary files a/www/images/backtrace-images-win32/dbg_options.png and /dev/null
differ
diff --git a/www/images/backtrace-images-win32/dbg_select_php.png
b/www/images/backtrace-images-win32/dbg_select_php.png
deleted file mode 100644
index 1a37a89..0000000
Binary files a/www/images/backtrace-images-win32/dbg_select_php.png and
/dev/null differ
diff --git a/www/images/backtrace-images-win32/dbg_wizard_1.png
b/www/images/backtrace-images-win32/dbg_wizard_1.png
deleted file mode 100644
index 6ef5517..0000000
Binary files a/www/images/backtrace-images-win32/dbg_wizard_1.png and /dev/null
differ
diff --git a/www/images/backtrace-images-win32/dbg_wizard_2.png
b/www/images/backtrace-images-win32/dbg_wizard_2.png
deleted file mode 100644
index 74cf4c9..0000000
Binary files a/www/images/backtrace-images-win32/dbg_wizard_2.png and /dev/null
differ
diff --git a/www/images/backtrace-images-win32/rules.jpg
b/www/images/backtrace-images-win32/rules.jpg
deleted file mode 100644
index 1c60ae9..0000000
Binary files a/www/images/backtrace-images-win32/rules.jpg and /dev/null differ
diff --git a/www/quick-fix-desc.php b/www/quick-fix-desc.php
index 00d1b62..d91ac70 100644
--- a/www/quick-fix-desc.php
+++ b/www/quick-fix-desc.php
@@ -8,7 +8,12 @@ list($RESOLVE_REASONS, $FIX_VARIATIONS) =
get_resolve_reasons($site);
response_header('Quick Fix Descriptions');
?>
-<table border="1" cellpadding="3" cellspacing="1">
+<table border="0" class="standard">
+<tr>
+ <th>Quick fix</th>
+ <th>Status</th>
+ <th>Message</th>
+</tr>
<?php
foreach ($RESOLVE_REASONS as $key => $reason) {
diff --git a/www/search-howto.php b/www/search-howto.php
index 8b23638..7dc4cb7 100755
--- a/www/search-howto.php
+++ b/www/search-howto.php
@@ -30,23 +30,23 @@ Load the advanced search to view the default values.
Some explanations for most of the PHP bugs <a href="search.php">advanced
search</a>
options.
</p>
-<table cellpadding="2" cellspacing="0" border="1" bgcolor="#eeeeee">
- <tr class="headerbottom" align="left">
- <td><strong>Feature</strong></td>
- <td><strong>Explanation</strong></td>
- <td><strong>Possible reasons for use</strong></td>
+<table border="0" class="standard">
+ <tr>
+ <th>Feature</th>
+ <th>Explanation</th>
+ <th>Possible reasons for use</th>
</tr>
- <tr valign="top">
+ <tr>
<td>Find bugs</td>
<td>
The main search text box for your search terms with
each term being separated
by a space. The searched database fields are: author
email, subject, and description.
Minimum term length is three characters. There are
three types of searches:
<ul>
- <li><i>all</i> : (default) All search terms are
required.</li>
- <li><i>any</i> : One or more (any) of the
search terms may be present.</li>
+ <li><i>all</i>: (default) All search terms are
required.</li>
+ <li><i>any</i>: One or more (any) of the search
terms may be present.</li>
<li>
- <i>raw</i> : Allows full use of MySQL's
+ <i>raw</i>: Allows full use of MySQL's
<a
href="http://www.mysql.com/doc/en/Fulltext_Search.html";>FULLTEXT</a>
boolean search operators.
</li>
@@ -93,7 +93,7 @@ options.
</td>
<td>If you're only interested in critical bugs, or want to see
which have been verified, or perhaps just those seeking feedback.</td>
</tr>
- <tr valign="top">
+ <tr>
<td>Category</td>
<td>
Bugs are categorized although sometimes it might seem
like a bug could be in
@@ -103,7 +103,7 @@ options.
</td>
<td> </td>
</tr>
- <tr valign="top">
+ <tr>
<td>OS</td>
<td>
Bugs that may be specific to an operating system. This
value is entered in by the
@@ -114,7 +114,7 @@ options.
</td>
<td>Although not an accurate field, it may be of some use.</td>
</tr>
- <tr valign="top">
+ <tr>
<td>Version</td>
<td>
Limit bugs to a specific version of PHP. A one
character integer of 3, 4 or
@@ -127,7 +127,7 @@ options.
version information.
</td>
</tr>
- <tr valign="top">
+ <tr>
<td>Assigned</td>
<td>
Some bugs get assigned to PHP developers, in which case
you may specify by
@@ -135,12 +135,12 @@ options.
</td>
<td>Example use is limiting the bugs assigned to yourself.</td>
</tr>
- <tr valign="top">
+ <tr>
<td>Author email</td>
<td>Takes on an email address of the original author of a
bug.</td>
<td>Looking for all bugs that a particular person
initiated.</td>
</tr>
- <tr valign="top">
+ <tr>
<td>Date</td>
<td>
Limit bugs that were reported by a specific time
period. This is not only the
@@ -154,11 +154,4 @@ options.
</tr>
</table>
-<h1>Bug System Statistics</h1>
-
-<p>
-You can view a variety of statistics about the bugs that have been
-reported on our <a href="stats.php">bug statistics page</a>.
-</p>
-
<?php response_footer();--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
![[PHP-WEBMASTER] com web/bugs: Minor adjustments for simpler pages like "How to report" or "Search howto": www/assets/css/style.css www/assets/images/backtrace-images-win32/analyze.jpg www/assets/images/backtrace-images-win32/backtrace.jpg www/assets/images/backtrace-images-win32/dbg_options.png www/assets/images/backtrace-images-win32/dbg_select_php.png www/assets/images/backtrace-images-win32/dbg_wizard_1.png www/assets/images/backtrace-images-win32/dbg_wizard_](/search?l=php-webmaster@lists.php.net&q=subject:%22%5C%5BPHP%5C-WEBMASTER%5C%5D+com+web%5C%2Fbugs%5C%3A+Minor+adjustments+for+simpler+pages+like+%5C%22How+to+report%5C%22+or+%5C%22Search+howto%5C%22%5C%3A+www%5C%2Fassets%5C%2Fcss%5C%2Fstyle.css+www%5C%2Fassets%5C%2Fimages%5C%2Fbacktrace%5C-images%5C-win32%5C%2Fanalyze.jpg+www%5C%2Fassets%5C%2Fimages%5C%2Fbacktrace%5C-images%5C-win32%5C%2Fbacktrace.jpg+www%5C%2Fassets%5C%2Fimages%5C%2Fbacktrace%5C-images%5C-win32%5C%2Fdbg_options.png+www%5C%2Fassets%5C%2Fimages%5C%2Fbacktrace%5C-images%5C-win32%5C%2Fdbg_select_php.png+www%5C%2Fassets%5C%2Fimages%5C%2Fbacktrace%5C-images%5C-win32%5C%2Fdbg_wizard_1.png+www%5C%2Fassets%5C%2Fimages%5C%2Fbacktrace%5C-images%5C-win32%5C%2Fdbg_wizard_%22&o=newest){kind=link}
