Commit: 5cd67eadf9903bfef2864d0c2dbdcda2d874fd97 Author: Sobak <msobaczew...@gmail.com> Sun, 19 Apr 2020 07:43:07 +0200 Parents: 6e4fd55e99457199d043e0255fc51a283f89dc45 Branches: master
Link: http://git.php.net/?p=web/master.git;a=commitdiff;h=5cd67eadf9903bfef2864d0c2dbdcda2d874fd97 Log: Notes: fix pagination I feel like this empty() check is also incorrect in other places but I don't know how to reproduce the potential issue so maybe better it's to not touch it. Changed paths: M manage/user-notes.php Diff: diff --git a/manage/user-notes.php b/manage/user-notes.php index 9a960db..a96e519 100644 --- a/manage/user-notes.php +++ b/manage/user-notes.php @@ -375,7 +375,7 @@ if (!$action) { "number of votes placed in a small timeframe to help detect spam and other potential abuse.</p>\n". "<p>Also note that a <em>0.0.0.0</em> IP address indicates a client IP could not be resolved at the time of voting.</p>"; } - if((isset($_REQUEST["view"]) || isset($_REQUEST['keyword'])) && empty($search_votes)) { + if((isset($_REQUEST["view"]) || isset($_REQUEST['keyword'])) && isset($search_votes) && $search_votes === true) { $keyword = isset($_REQUEST['keyword']) ? '&keyword=' . urlencode($_REQUEST['keyword']) : ''; // Setting type is here only to avoid notice or more conditions. // It won't cause to show last notes (type=0) as $_REQUEST['keyword'] presence has higher priority. -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
