Author: peterdd (peterdd)
Committer: GitHub (web-flow)
Pusher: rlerdorf
Date: 2021-10-06T12:31:50-07:00

Commit: 
https://github.com/php/web-bugs/commit/90f86d6ab964d58d9f2f454d591d40b868ee75a4
Raw diff: 
https://github.com/php/web-bugs/commit/90f86d6ab964d58d9f2f454d591d40b868ee75a4.diff

add css classes to status select in search form (#106)

Reuses the existing CSS classes to apply the same backgorund colors as in the 
bug search result table rows.

I know that Chrome and Safari ignore applying a background-color to option tags 
of a single select. But when bugs.php.net supports also multiselect for the 
status select both will show the background-color in multi selects 
(multiple="multiple" attribute for xhtml compatible modus)

Changed paths:
  M  include/functions.php


Diff:

diff --git a/include/functions.php b/include/functions.php
index b72c2c8c..e0e3b6fb 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -495,7 +495,7 @@ function show_type_options($current = 'Bug', $all = false)
  */
 function show_state_options($state, $user_mode = 0, $default = '', $assigned = 
0)
 {
-    global $state_types;
+    global $state_types, $tla;
 
     if (!$state && !$default) {
         $state = $assigned ? 'Assigned' : 'Open';
@@ -512,21 +512,25 @@ function show_state_options($state, $user_mode = 0, 
$default = '', $assigned = 0
              */
             case 'Feedback':
                 if ($assigned) {
-                    echo "<option>Assigned</option>\n";
+                    echo '<option 
class="'.$tla['Assigned'].'">Assigned</option>'."\n";
                 } else {
-                    echo "<option>Open</option>\n";
+                    echo '<option class="'.$tla['Open'].'">Open</option>'."\n";
                 }
                 break;
             case 'No Feedback':
-                echo "<option>Re-Opened</option>\n";
+                echo '<option 
class="'.$tla['Re-Opened'].'">Re-Opened</option>'."\n";
                 break;
             default:
-                echo "<option>$state</option>\n";
+                echo '<option';
+                if (isset($tla[$state])) {
+                    echo ' class="'.$tla[$state].'"';
+                }
+                echo '>'.$state.'</option>'."\n";
                 break;
         }
         /* Allow state 'Closed' always when current state is not 'Not a bug' */
         if ($state != 'Not a bug') {
-            echo "<option>Closed</option>\n";
+            echo '<option class="'.$tla['Closed'].'">Closed</option>'."\n";
         }
     } else {
         foreach($state_types as $type => $mode) {
@@ -536,6 +540,9 @@ function show_state_options($state, $user_mode = 0, 
$default = '', $assigned = 0
             }
             if ($mode >= $user_mode) {
                 echo '<option';
+                if (isset($tla[$type])) {
+                    echo ' class="'.$tla[$type].'"';
+                }
                 if ($type == $state) {
                     echo ' selected="selected"';
                 }

-- 
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to