> > 2/ Although I want to solve the dom problem, I don't want
> to hard code dom
> > specifics into the guts of livedocs
> So how? How do you know if you to append 'dom-' to the id?
There should be a generic mechanism to name functions based on the extension
that they are in.
> > 3/ the version stuff is not phpdoc specific; it can happily
> live in the
> > default theme.
> No! PHPDOC is the only using the version stuff. With your
> modified patch, it
> works perfectly, because you are doing:
> if ($q && LATEST_VERSION == $q) {
This is correct.
> and I think the correct version would be:
> if (!$q || LATEST_VERSION == $q) {
>
> because If there is no version information on the DB, it is
> considered as
> 'CVS only', so it is only avaliable in latest version.
This is incorrect; read the comment in the source.
Not everything has version info (such as include/require) and this is showing
up incorrectly.
> Sorry, but I have tons of patches to livedocs... :) The
> issues adressed in
> the patch I sent are:
> * fixed a small problem with the message for outdated translations
> * fetch english entites if the translated aren't avaliable (in
> bind_entities)
> * a fix for references pages, like SPL or Tidy (make_function_link)
> * fix PCRE problem (handle_include)
> * hard-coded a fix for dom
> * small improvement for format_listing_hyperlink_function
> (don't link a
> function if $id== $current_page)
>
> I think thats all! ;-)
Can you please post one patch per issue? (I know it's a pain in the ass)
--Wez.
