ID:               34124
 User updated by:  ondrej at sury dot org
 Reported By:      ondrej at sury dot org
 Status:           Closed
 Bug Type:         Documentation problem
 Operating System: Linux
 PHP Version:      5.0.4
 Assigned To:      sean
 New Comment:

I was just not sure, what's upstream policy on these kind of bugs.  Now
I know, so next bugs will be better :-).

Thanks for fix.


Previous Comments:
------------------------------------------------------------------------

[2005-08-13 21:06:44] [EMAIL PROTECTED]

This bug has been fixed in the documentation's XML sources. Since the
online and downloadable versions of the documentation need some time
to get updated, we would like to ask you to be a bit patient.

Thank you for the report, and for helping us make our documentation
better.



------------------------------------------------------------------------

[2005-08-13 20:55:59] [EMAIL PROTECTED]

Ifit's a documentation problem... make sure you set the category to
"Documentation problem" then...

------------------------------------------------------------------------

[2005-08-13 15:31:49] ondrej at sury dot org

As I stated in original bug report, it could be just lack of note in
docs.

I guess that problem original submitter had was, that it's pretty
normal that variables in PHP can be used without initialization, it
prints WARNING, but in the end it works as expected.  Also
documentation states that array_push has same effect as $array[] =
$var, which is not true, because [] statement creates array.


So I guess simple adding:

"NOTE: array_push will not create array when called with non-array
argument."

to docs won't hurt.  And it could avoid confusion on user side.

------------------------------------------------------------------------

[2005-08-13 15:19:28] [EMAIL PROTECTED]

Ever tried to set display_errors to On and error_reporting to E_ALL ?

This is what your code outputs.:
Warning: array_push(): First argument should be an array in ..

I don't see any bugs here.

------------------------------------------------------------------------

[2005-08-13 15:14:15] ondrej at sury dot org

Description:
------------
>From http://bugs.debian.org/289244:

array_push will not create new array when called with arg which is not
array type (or nonexistant).

This could be just documentation error to state, that new array won't
be created inside array_push().

I am not sure that there is easy fix inside PHP, since array parameter
in array_push is reference and not value.  So it looks like that it
gets created inside array_push, but discarded (or leaked?) afterwards.

Reproduce code:
---------------
<?php
array_push ($foo, 1, 2, 3);
print ("bar $foo[0] baz\n");
?>


Expected result:
----------------
bar 1 baz

Actual result:
--------------
bar  baz


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=34124&edit=1

Reply via email to