Re: [PHP-DOC] configure.in patch

[Sveta Smirnova]

Hello, Gabor! As remind Jakub Vrana, I can use C:\Progra~1. So it is not so inconvinient as I think before and I am not insisting the patch should be commited :-) But as I will use whitespaces in paths and periodically build manual, I can support this feature and I am not afraid to change more than one file. Regards, Sveta. Gabor Hojtsy wrote: Well, Sveta, I am not strictly against supporting spaces in the PHP installation path, but this is just the beginning of some big changes, if you really would like to support spaces in paths. I think you are going to face several problems in the phpdoc build system, if you use path values with spaces. That said, unless it breaks something, I don't think it would be a problem applying your patch (I am unable to try it now), but I would like to warn you that it will probably not solve the space in path values issue alltogether. Goba sveta wrote: Hello Gabor! In Windows default place for programs is "C:\Program Files\Program_name". "C:\Program Files" contains whitespace. Installing of all programs in different places is inconvinient. For example people don't raise an objection when UNIX-based operation systems require install programs in /usr/local/bin. I understand why you don't want to change this behavior, but I've only found same path in Makefile.in So if you agree to support "whitespaces in paths" I can change build scripts for it :-) Regards, Sveta. Gabor Hojtsy wrote: Hi Sveta, Sveta Smirnova wrote: Hello! When I tried to build copy of manual using configure option --with-php="path with whitespaces", I got error. In attached diff patch, allows use whitespaces in paths. Regards, Sveta. What does a space char do in a path? :) Seriosly, this path is used elsewhere in the build system, and I think it is not "as easy" as "fixing" only configure.in. You'd better follow our instructions and not put PHP into a path with spaces in it IMHO. Gabor