Hi.

Using the above patch (which includes a revert of
http://cvs.php.net/viewvc.cgi/phpdoc/configure.php?r1=1.44&r2=1.45, I
can successfully use the --srcdir.

It seems that the relative paths in the entity type files are relative
to the xml file that included it.

E.g.

manual.xml requires ./entities/file-entities.ent
and
file-entities.ent requires ../en/bookinfo.xml


So, this is working for me on Windows and with Cygwin using windows PHP.


Having said all of that, by fixing the relative pathing, the --srcdir
option is redundant as $ac['srcdir'] === dirname(__FILE__) in most
cases.

Before I commit this, can you unix people test it please.

The following all work.

[in D:\phd\phpdoc] configure.php
[in D:\phd] .\phpdoc\configure.php
[in D:\phd] .\phpdoc\configure.php --srcdir=D:\phd\phpdoc
[in C:\] D:\phd\phpdoc\configure.php
[in C:\] D:\phd\phpdoc\configure.php --srcdir=D:\phd\phpdoc

If there is a reason to keep srcdir, then fine - if someone can tell
me why I can test it.

But I think it can be removed.

Thanks.

Richard.

-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"

Attachment: phpdoc.patch
Description: Binary data

Reply via email to