2008/12/24 Daniel Convissor <dani...@analysisandsolutions.com>:
> Hi Simion:
>
> On Wed, Dec 24, 2008 at 02:19:28PM +0200, Simion Onea wrote:
>>
>> --- constants.xml       19 Dec 2008 07:52:28 -0000      1.5
> ...
>> -  The following constants indicates an error type returned
>> -  by <function>json_last_error</function> and are all available
>> -  as of PHP 5.3.0.
>> +  The following constants indicate the type of error returned by
>> +  <function>json_last_error</function> and are all available as
>> of PHP 5.3.0.
>
> Your changes overall are good.  I'd break that one up in to two
> sentences (error returned first one, availablility second one).

Thanks, I'll do that.

> Folks: I just spent some time looking for the style guide for the PHP
> manual and couldn't find it.  (I recall it covering whether to use "as
> of" vs "since" for change log stuff as well as suggesting what column to
> wrap lines at.)  Anyone remember where that is, please?

Probably "since" should be used in expressions such as "available
since PHP 5.3.0" and "as of" should be used in expressions such as "no
longer valid as of PHP 5.3.0".

Reply via email to