On Sat, May 22, 2010 at 19:23, Philip Olson <phi...@php.net> wrote:
> philip                                   Sat, 22 May 2010 17:23:13 +0000
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=299628
>
> Log:
> Implemented new version.trunk. entities
>
> Changed paths:
>    U   phpdoc/en/trunk/reference/image/functions/imagecolorset.xml
>    U   phpdoc/en/trunk/reference/json/functions/json-decode.xml
>
> Modified: phpdoc/en/trunk/reference/image/functions/imagecolorset.xml
> ===================================================================
> --- phpdoc/en/trunk/reference/image/functions/imagecolorset.xml 2010-05-22 
> 17:09:43 UTC (rev 299627)
> +++ phpdoc/en/trunk/reference/image/functions/imagecolorset.xml 2010-05-22 
> 17:23:13 UTC (rev 299628)
> @@ -64,8 +64,11 @@
>      <term><parameter>alpha</parameter></term>
>      <listitem>
>       <para>
> -       Value of alpha component. This parameter is only available in SVN 
> (trunk).
> +       Value of alpha component.
>       </para>
> +      <para>
> +       &version.trunk.after.53;
> +      </para>

We don't document version requirements inline, its only in the changelog.



> + <refsect1 role="changelog">
> +  &reftitle.changelog;
> +  <informaltable>
> +   <tgroup cols="2">
> +    <thead>
> +     <row>
> +      <entry>&Version;</entry>
> +      <entry>&Description;</entry>
> +     </row>
> +    </thead>
> +    <tbody>
> +     <row>
> +      <entry>&version.trunk.changelog;</entry>
> +      <entry>
> +       The <parameter>alpha</parameter> parameter was added.


"Future" doesn't sound that good.

Imaging the following table:

Future | $foo was added
5.2.1 | $foobar was added

Whattaheck is future? It at least has to be a link to the about version page.


> Modified: phpdoc/en/trunk/reference/json/functions/json-decode.xml
> ===================================================================
> --- phpdoc/en/trunk/reference/json/functions/json-decode.xml    2010-05-22 
> 17:09:43 UTC (rev 299627)
> +++ phpdoc/en/trunk/reference/json/functions/json-decode.xml    2010-05-22 
> 17:23:13 UTC (rev 299628)
> @@ -57,6 +57,9 @@
>        <constant>JSON_BIGINT_AS_STRING</constant>
>        is supported (default is to cast large integers as floats)
>       </para>
> +      <para>
> +       &version.trunk.after.53;
> +      </para>

Same here, we never say the version inline for functions. That is what
the changelog is for.


-Hannes

Reply via email to