Thanks Philip for the feedback. I started to do all the clean up you suggested. I will continue to document later tonight.
On Mon, Oct 25, 2010 at 9:51 AM, Philip Olson <phi...@roshambo.org> wrote: > > On Oct 24, 2010, at 5:00 PM, Nicolas Brousse wrote: > >> Hi, >> >> Last month I did a php binding for the libJudy, It's in pecl, I also >> started to do the doc, you can find it here : >> http://svn.php.net/viewvc/pecl/judy/trunk/doc/ >> >> Is there any requirement to get this on the site ? Should I commit the >> chunked xhtml version ? Btw, I could do the doc in English and French >> if needed. > > Greetings Nicolas, > > Please commit the XML as we generate the HTML every week. Also it looks good > but a few minor notes: > > - Please fix the whitespace. One space, no tabs, and lines should be around > 80 characters although not a major deal (just not 200... ;) > - Don't commit entities.* files or book.developer.xml > - Please change the "ReturnType" and "Description" place holders before > committing > - And please update the versions.xml before committing > > Then, commit as phpdoc/en/trunk/reference/judy/, and the > doc-base/manual.xml.in change. Excellent :) > > Regards, > Philip > > >
