On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson <phi...@roshambo.org> wrote:
>
> On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote:
>
>> Hi,
>>
>> Attached is a patch to add examples to the documentation for
>> AMQPQueue::get and AMQPQueue::ack.
>
>
> Hello Bradley,
>
> Looks good. A few minor issues:
>
>  - Use <methodname> for all methods. Sometimes you used <function>.
>   Both work but, well, I did say "minor" issues :)
>  - PHP code indentation should be 4 spaces instead of the XML
>   friendly 1
>

These examples (with the above changes) have been added in r315574.

> Also, your SVN account request has been approved with phpdoc karma
> granted, welcome to the PHP Documentation team! :)
>
> Regards,
> Philip
>
>
>

Reply via email to