> From: Maât [[email protected]] > Sent: 2009-11-24 10:14:29 CET > To: [email protected] > Subject: Re: [phpGroupWare-developers] Code available for test > > Sigurd Nes wrote: > > > >> wow... > >> > >> subversion log living again :) > >> > >> just one question (i'm curious) do subversion repos and this tar.gz > >> contain the same code ? > >> > >> if no which one is ahead ? > >> > >> > > It is identical (to the date) - it's just to spare peopel of having to deal > > with svn:externals. > > > Wooohooo ! Then i can test it with a checkout and compare trees \o/ > > Thanks :) > > > email is from phpgroupware/modules/email/trunk - the rest is from > > phpgroupware/people/sigurdne... > > > > (I took the liberty of tuning the email-app directly without going via the > > personal repository - as this is minor fixes) > > > I looked at the patches... yeah they all seem minor and positive fixes > so no problem for me. > > > May i just suggest something for the future ? > > I'd like we all think about commit log standardization so that we have > more presision and the possibility to create changelogs automatically later. > > I's suggest for example something like a beginning tag > > Bug fix : <-- patche that fix wrong code > Security fix : <-- obvious isn't it ? :) > Code formatting : <-- this one just for indentation and other chenges > that do not change the code > Code cleaning : <-- this one for php modernization and other changes > that do change the code but do not change the resulting behavior > New feature : <-- this one new cool feature > ... > > (we would of course need to define the precise list of possible tags) > > And i'd suggest that a commit concerns only one specific point > > for example i'd rather have seen change set [20890] Fix search (not > happy with non-ascii) splitted in two : > > -- one for the php code modernization : > Code cleaning : changing from $GLOBALS['HTTP_POST_VARS'] to $_POST and > removing trailing ?> > > -- One for the real fixing part : > Bug fix : Fix search problem with non-ascii > > > That suggestion is not supposed to be taken "as it is" but rather to be > the start point of a common work to improve it so that we end with > some nice rules for svn management :) > > > (Btw i did not understand this non-ascii problem by just reading your > changes... would you mind to explain the problem and the fix to me please ?) > The search didn't work at all - now it works at least with ascii. Tried to play with different encoding - like imap_utf7_encode() to the criteria applied to imap_search - but no luck. Maybe you can have a go at it? The actual search is performed in class.mail_dcom_imap.inc.php, function: i_search() around line 243.
The only (other) thing (I think) remaining - is the filter feature - seems like a object wasn't initialized.... Maybe you can see at it with fresh eyes? Regards Sigurd
_______________________________________________ phpGroupWare-developers mailing list [email protected] http://lists.gnu.org/mailman/listinfo/phpgroupware-developers
