Sigurd Nes a écrit : > Caeies wrote: >> Revision: 20896 >> >> http://svn.sv.gnu.org/viewvc/?view=rev&root=phpgroupware&revision=20896 >> Author: Caeies >> Date: 2009-11-25 16:35:37 +0000 (Wed, 25 Nov 2009) >> Log Message: >> ----------- >> Bug fix : check for already encoded utf8 stuff ... instead of forcing >> it in all cases since utf8_encode(utf8_encode(X)) != utf_8_encode(X) >> if X is not pure ascii >> >> Modified Paths: >> -------------- >> modules/email/trunk/inc/class.mail_msg_base.inc.php >> >> Modified: modules/email/trunk/inc/class.mail_msg_base.inc.php >> =================================================================== >> --- modules/email/trunk/inc/class.mail_msg_base.inc.php 2009-11-25 >> 16:06:05 UTC (rev 20895) >> +++ modules/email/trunk/inc/class.mail_msg_base.inc.php 2009-11-25 >> 16:35:37 UTC (rev 20896) >> @@ -4437,7 +4437,7 @@ >> */ >> function ascii2utf($text = '') >> { >> - if ($text == utf8_encode($text)) >> + if ((function_exists('mb_detect_encoding') && >> mb_detect_encoding($text) == 'UTF-8')) >> { >> return $text; >> } >> > Hi Caeies, > > That one didn't work (for me). > the mb_detect_encoding($text) is detecting the text as utf-8 even if it > is ISO-8859-1 > > Please test.
You too. if ($text == utf8_encode($text)) is a non-sense with already utf8 non ascii-only text ... And I didn't put any comment on that in the commit ... But if you want me to insist on the garbage code on the public list, I will be happy to do so. Regards, Caeies. _______________________________________________ phpGroupWare-developers mailing list [email protected] http://lists.gnu.org/mailman/listinfo/phpgroupware-developers
