Follow-up Comment #2, patch #5374 (project phpgroupware):
Hi all
> * why is chdir used before include_once ? Just use include_once with the
right path
The main problem is that if we do that, we broke all the login stuff ... at
least on our version of php + phpgroupware.
> * I would like to see the prefs code be OOP'd and using XSLT, as it isn't
in the API this can be done later.
Work in progress :)
> * The phpdocs could do with a bit more work, especially the method
arguments :)
Clearly.
> * The link on the login screen, can that be a template block, so it is only
shown when SSO is enabled ?
I was thinking that it was already the case. I perhaps forgot something
somewhere :)
> * the css class "button_group" is for groups of buttons, not links.
> * All new templates in HEAD should use CSS not hard coded html attributes
such as bgcolor and other ugly things
So we create a new class like link_group ? in the base css ? I guess that
most of this comes from phpgw .16 and that's why ugly things are in :)
We will try to be as quick as possible.
Regards.
Caeies
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5374>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
phpGroupWare-tracker mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/phpgroupware-tracker
