[
https://issues.apache.org/jira/browse/PIG-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707193#action_12707193
]
Hadoop QA commented on PIG-734:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407585/PIG-734.patch
against trunk revision 772750.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 63 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 228 javac compiler warnings (more
than the trunk's current 225 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/32/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/32/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/32/console
This message is automatically generated.
> Non-string keys in maps
> -----------------------
>
> Key: PIG-734
> URL: https://issues.apache.org/jira/browse/PIG-734
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Minor
> Fix For: 0.3.0
>
> Attachments: PIG-734.patch
>
>
> With the addition of types to pig, maps were changed to allow any atomic type
> to be a key. However, in practice we do not see people using keys other than
> strings. And allowing multiple types is causing us issues in serializing
> data (we have to check what every key type is) and in the design for non-java
> UDFs (since many scripting languages include associative arrays such as
> Perl's hash).
> So I propose we scope back maps to only have string keys. This would be a
> non-compatible change. But I am not aware of anyone using non-string keys,
> so hopefully it would have little or no impact.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
