[ https://issues.apache.org/jira/browse/PIG-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737024#action_12737024 ]
Hadoop QA commented on PIG-513: ------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414853/pig-513_2.patch against trunk revision 799141. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/146/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/146/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/146/console This message is automatically generated. > PERFORMANCE: optimize some of the code in DefaultTuple > ------------------------------------------------------ > > Key: PIG-513 > URL: https://issues.apache.org/jira/browse/PIG-513 > Project: Pig > Issue Type: Bug > Affects Versions: 0.2.0 > Reporter: Pradeep Kamath > Assignee: Pradeep Kamath > Attachments: PIG-513.patch, pig-513_2.patch > > > The following areas in DefaultTuple.java can be changed: > The member methods get(), set(), getType() and isNull() all call > checkBounds() which is redundant call since all these 4 functions throw > ExecException. Instead of doing a bounds check, we can catch the > IndexOutOfBounds exception in a try-catch and throw it as an ExecException > The write() method has the following unused object (d in the code below): > {code} > for (int i = 0; i < sz; i++) { > try { > Object d = get(i); > } catch (ExecException ee) { > throw new RuntimeException(ee); > } > DataReaderWriter.writeDatum(out, mFields.get(i)); > } > {code} > {noformat} > The get(i) call in the try should be replaced by the writeDatum call directly > since d is never used and there is an unncessary call to get() > {noformat} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.