[ https://issues.apache.org/jira/browse/PIG-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749196#action_12749196 ]
Dmitriy V. Ryaboy commented on PIG-934: --------------------------------------- Throwing an exception when a seek is past the file boundary seems acceptable to me (and preferable to adding new functions and changing upstream code that shouldn't care about this detail). Especially since if there is a way to get a consistent ordering among files in a directory, it's trivial to later update this code to seek past file boundaries and into the next file. > Merge join implementation currently does not seek to right point on the right > side input based on the offset provided by the index > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: PIG-934 > URL: https://issues.apache.org/jira/browse/PIG-934 > Project: Pig > Issue Type: Bug > Affects Versions: 0.3.1 > Reporter: Pradeep Kamath > Assignee: Ashutosh Chauhan > Attachments: pig-934.patch > > > We use POLoad to seek into right file which has the following code: > {noformat} > public void setUp() throws IOException{ > String filename = lFile.getFileName(); > loader = > (LoadFunc)PigContext.instantiateFuncFromSpec(lFile.getFuncSpec()); > is = FileLocalizer.open(filename, pc); > loader.bindTo(filename , new BufferedPositionedInputStream(is), > this.offset, Long.MAX_VALUE); > } > {noformat} > Between opening the stream and bindTo we do not seek to the right offset. > bindTo itself does not perform any seek. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.