[ https://issues.apache.org/jira/browse/PIG-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755808#action_12755808 ]
Ashutosh Chauhan commented on PIG-865: -------------------------------------- Ouch... It should have been atleast at par if not better ! Reading the code, I can see there are more opportunities to optimize here. Currently, I am trying to get an access on M45, once I get it I will run few benchmarks and report back if I see improvements. > Performance: Unnnecessary computation in FRJoin > ----------------------------------------------- > > Key: PIG-865 > URL: https://issues.apache.org/jira/browse/PIG-865 > Project: Pig > Issue Type: Improvement > Components: impl > Affects Versions: 0.3.0 > Reporter: Ashutosh Chauhan > Assignee: Ashutosh Chauhan > Priority: Minor > Attachments: pig-865.patch, pig-865_v2.patch > > > In POFRJoin implementation POLocalRearrange is used to extract join keys from > the input tuples. If keys match then to perform actual join input tuples are > fed to Foreach which does a cross on its inputs. After keys are extracted > using POLocalRearrange output; function getValueTuple(POLocalRearrange lr, > Tuple tuple) is called to reconstruct the input tuple. It seems that this > function call is unnecessary since we already have input tuple at that time. > This is not a bug, but since this function would get called for every tuple, > if it is eliminated, it should certainly help to improve performance. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.