[ https://issues.apache.org/jira/browse/PIG-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760792#action_12760792 ]
Daniel Dai commented on PIG-960: -------------------------------- Couple of comments: 1. Why PigLineRecordReader inherits BufferedPositionedInputStream? Shouldn't it just be a wrapper? 2. In PigStorage.skip, you do not count line delimit when skipping? 3. Why not add a test case for skip? 4. Two typos "Excpected" > Using Hadoop's optimized LineRecordReader for reading Tuples in PigStorage > --------------------------------------------------------------------------- > > Key: PIG-960 > URL: https://issues.apache.org/jira/browse/PIG-960 > Project: Pig > Issue Type: Improvement > Components: impl > Reporter: Ankit Modi > Attachments: pig_rlr.patch > > > PigStorage's reading of Tuples ( lines ) can be optimized using Hadoop's > {{LineRecordReader}}. > This can help in following areas > - Improving performance reading of Tuples (lines) in {{PigStorage}} > - Any future improvements in line reading done in Hadoop's > {{LineRecordReader}} is automatically carried over to Pig > Issues that are handled by this patch > - BZip uses internal buffers and positioning for determining the number of > bytes read. Hence buffering done by {{LineRecordReader}} has to be turned off > - Current implementation of {{LocalSeekableInputStream}} does not implement > {{available}} method. This method has to be implemented. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.