[
https://issues.apache.org/jira/browse/PIG-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765896#action_12765896
]
Hadoop QA commented on PIG-1018:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422153/PIG-1018.patch
against trunk revision 825308.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 315 release audit warnings
(more than the trunk's current 309 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/80/testReport/
Release audit warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/80/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/80/console
This message is automatically generated.
> FINDBUGS: NM_FIELD_NAMING_CONVENTION: Field names should start with a lower
> case letter
> ---------------------------------------------------------------------------------------
>
> Key: PIG-1018
> URL: https://issues.apache.org/jira/browse/PIG-1018
> Project: Pig
> Issue Type: Bug
> Reporter: Olga Natkovich
> Attachments: PIG-1018.patch
>
>
> Nm The field name
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.LogToPhyTranslationVisitor.LogToPhyMap
> doesn't start with a lower case letter
> Nm The method name
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.CreateTuple(Object[])
> doesn't start with a lower case letter
> Nm The class name
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.util.operatorHelper
> doesn't start with an upper case letter
> Nm Class org.apache.pig.impl.util.WrappedIOException is not derived from
> an Exception, even though it is named as such
> Nm The method name
> org.apache.pig.pen.EquivalenceClasses.GetEquivalenceClasses(LogicalOperator,
> Map) doesn't start with a lower case letter
> Nm The field name org.apache.pig.pen.util.DisplayExamples.Result doesn't
> start with a lower case letter
> Nm The method name
> org.apache.pig.pen.util.DisplayExamples.PrintSimple(LogicalOperator, Map)
> doesn't start with a lower case letter
> Nm The method name
> org.apache.pig.pen.util.DisplayExamples.PrintTabular(LogicalPlan, Map)
> doesn't start with a lower case letter
> Nm The method name
> org.apache.pig.tools.parameters.TokenMgrError.LexicalError(boolean, int, int,
> int, String, char) doesn't start with a lower case letter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.