[ https://issues.apache.org/jira/browse/PIG-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792578#action_12792578 ]
Pradeep Kamath commented on PIG-1149: ------------------------------------- I tried applying it on the branch and it failed: {noformat} :/tmp/load-store-redesign]patch -p0 < /homes/pradeepk/dev/pig-apache/pig/trunk/pig_1149.patch patching file src/org/apache/pig/impl/builtin/SampleLoader.java Hunk #1 succeeded at 31 with fuzz 2 (offset -4 lines). Hunk #2 FAILED at 46. 1 out of 2 hunks FAILED -- saving rejects to file src/org/apache/pig/impl/builtin/SampleLoader.java.rej patching file test/org/apache/pig/test/TestPoissonSampleLoader.java [prade...@chargesize:/tmp/load-store-redesign] {noformat} Since Thejas worked on PIG-1062, he might be in a better position to check whether this patch needs changes. > Allow instantiation of SampleLoaders with parametrized LoadFuncs > ---------------------------------------------------------------- > > Key: PIG-1149 > URL: https://issues.apache.org/jira/browse/PIG-1149 > Project: Pig > Issue Type: Bug > Reporter: Dmitriy V. Ryaboy > Assignee: Dmitriy V. Ryaboy > Priority: Minor > Fix For: 0.7.0 > > Attachments: pig_1149.patch > > > Currently, it is not possible to instantiate a SampleLoader with something > like PigStorage(':'). We should allow passing parameters to the loaders > being sampled. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.