[ 
https://issues.apache.org/jira/browse/PIG-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792688#action_12792688
 ] 

Alan Gates commented on PIG-1141:
---------------------------------

In DefaultInputHandler.close, why was the code that flushes and closes stdin 
removed?  Same question for DefaultOutputHandler and stdout.  It seems like we 
still need to flush and close these streams properly.

Similar to the above, close was removed from FileOutputHandler (but not 
FileInputHandler).

Both PigToStream and StreamToPig interfaces should have some javadoc comments 
for the interface explaining what they do and why.

In StorageUtil.parseFieldDel, you call Integer.valueOf(String) for both \u and 
\x.  For \x you should instead use Integer.valueOf(String, 16).


> Make streaming work with the new load-store interfaces 
> -------------------------------------------------------
>
>                 Key: PIG-1141
>                 URL: https://issues.apache.org/jira/browse/PIG-1141
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>         Attachments: PIG-1141.patch, PIG-1141.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to