[
https://issues.apache.org/jira/browse/PIG-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799493#action_12799493
]
Pradeep Kamath commented on PIG-1090:
-------------------------------------
Review comments for PIG-1090-12.patch:
1) I noticed that in JobControlCompiler, there is a call to setStoreLocation
besides a call to checkSchema(). If the setStoreLocation is not needed, maybe
it can removed since this method is called in PigOutputFormat. Also, please
update the comments in StoreFunc.checkschema to mention that the method is
called only if schema of the data is not null.
2) Comments in PigOutputFormat in places where setUpUdfContext() is called
would be useful
> Update sources to reflect recent changes in load-store interfaces
> -----------------------------------------------------------------
>
> Key: PIG-1090
> URL: https://issues.apache.org/jira/browse/PIG-1090
> Project: Pig
> Issue Type: Sub-task
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Attachments: PIG-1090-10.patch, PIG-1090-11.patch, PIG-1090-12.patch,
> PIG-1090-13.patch, PIG-1090-2.patch, PIG-1090-3.patch, PIG-1090-4.patch,
> PIG-1090-6.patch, PIG-1090-7.patch, PIG-1090-8.patch, PIG-1090-9.patch,
> PIG-1090.patch, PIG-1190-5.patch
>
>
> There have been some changes (as recorded in the Changes Section, Nov 2 2009
> sub section of http://wiki.apache.org/pig/LoadStoreRedesignProposal) in the
> load/store interfaces - this jira is to track the task of making those
> changes under src. Changes under test will be addresses in a different jira.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
