[ https://issues.apache.org/jira/browse/PIG-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801162#action_12801162 ]
Hadoop QA commented on PIG-1195: -------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430478/PIG-1195-1.patch against trunk revision 899502. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/179/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/179/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/179/console This message is automatically generated. > InternalSortedBag should take care of sort order > ------------------------------------------------ > > Key: PIG-1195 > URL: https://issues.apache.org/jira/browse/PIG-1195 > Project: Pig > Issue Type: Bug > Components: impl > Affects Versions: 0.6.0 > Reporter: Daniel Dai > Fix For: 0.6.0 > > Attachments: PIG-1195-1.patch > > > InternalSortedBag always use ascending order. We shall obey the sort order as > specified in the script. > For example, the following script does not do the right thing if we turn off > secondary sort (which means, we will rely on InternalSortedBag to sort): > {code} > A = load 'input' as (a0:int); > B = group A ALL; > C = foreach B { > D = order A by a0 desc; > generate D; > }; > dump C; > {code} > If we run it using the command line "java -Xmx512m > -Dpig.exec.nosecondarykey=true -jar pig.jar 1.pig". > The sort order for D is ascending. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.