[
https://issues.apache.org/jira/browse/PIG-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832346#action_12832346
]
Yan Zhou commented on PIG-1140:
-------------------------------
TableLoader:
seekNear(): should build static info once and only build dynamic data for
each and every call;
getNext(): should not need to make a copy of Tuple as a returned value;
TableInputFormat:
setProjection(Configuration conf, String projection) seems to be a utility
method and should be made private
createTableRecordReader needs to make sure only one split is generated
there are several unused "serialVersionUID" const variable introduced;
TableRecordWriter:
Should stay inside the BasicTableOutput.java
Constructor: better to build the inserter's name outside the loop; the
"patition" appearts to be a typo; why not use the original "part-" prefix? Is
the sequence number 0-padded at the front when necessary?
TableRecordReader:
nextKeyValue should not absorb the IOException: it should throw it without
printing the stack trace.
TableRecordReader:
tableRecordWriter: should not be a member variable;
> [zebra] Use of Hadoop 2.0 APIs
> --------------------------------
>
> Key: PIG-1140
> URL: https://issues.apache.org/jira/browse/PIG-1140
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.6.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.7.0
>
> Attachments: zebra.0209
>
>
> Currently, Zebra is still using already deprecated Hadoop 1.8 APIs. Need to
> upgrade to its 2.0 APIs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
