[ 
https://issues.apache.org/jira/browse/PIG-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836035#action_12836035
 ] 

Pradeep Kamath commented on PIG-966:
------------------------------------

LoadFunc is now an abstract class with default implementations for some of the 
methods - we hope this will aid implementers.  I would like to make the same 
change for StoreFunc. Since PigStorage currently does both load and store, we 
would need to also introduce an interface - StoreFuncInterface so that 
PigStorage can extend LoadFunc and implement StoreFuncInterface. To be 
symmetrical, we would need to also introduce a LoadFuncInterface. This 
interface can be used by implementers if they want their loadFunc 
implementation to extend some other class. We can document and recommend 
strongly to users to only use our abstract classes since that would be make 
them less vulnerable to incompatibile additions in the future (hopefully when 
we add new methods into these abstract classes we will give a default 
implementation).

I will upload a patch for this unless anyone has strong objections.

> Proposed rework for LoadFunc, StoreFunc, and Slice/r interfaces
> ---------------------------------------------------------------
>
>                 Key: PIG-966
>                 URL: https://issues.apache.org/jira/browse/PIG-966
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>
> I propose that we rework the LoadFunc, StoreFunc, and Slice/r interfaces 
> significantly.  See http://wiki.apache.org/pig/LoadStoreRedesignProposal for 
> full details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to