[
https://issues.apache.org/jira/browse/PIG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844385#action_12844385
]
Hadoop QA commented on PIG-1290:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438556/PIG-1290.patch
against trunk revision 922097.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/244/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/244/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/244/console
This message is automatically generated.
> WeightedRangePartitioner should not check if input is empty if quantile file
> is empty
> -------------------------------------------------------------------------------------
>
> Key: PIG-1290
> URL: https://issues.apache.org/jira/browse/PIG-1290
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0, 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1290.patch
>
>
> Currently WeightedRangePartitioner checks if the input is also empty if the
> quantile file is empty. For this it tries to read the input (which under the
> covers will result in creating splits for the input etc). If the input is a
> directory with many files, this could result in many calls to the namenode
> from each task - this can be avoided.
> If the input is non empty and quantile file is empty, then we would error out
> anyway (this should be confirmed). Also while fixing this jira we should
> ensure that pig can still do order by on empty input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
