[
https://issues.apache.org/jira/browse/PIG-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852269#action_12852269
]
Hadoop QA commented on PIG-1330:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12440308/PIG-1330-1.patch
against trunk revision 929737.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/274/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/274/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/274/console
This message is automatically generated.
> Move pruned schema tracking logic from LoadFunc to core code
> ------------------------------------------------------------
>
> Key: PIG-1330
> URL: https://issues.apache.org/jira/browse/PIG-1330
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1330-1.patch
>
>
> Currently, LoadFunc.getSchema require a schema after column pruning. The good
> side of this is LoadFunc.getSchema matches the data it actually load. This
> gives a sense of consistency. However, by doing this, every LoadFunc need to
> keep track of the columns pruned. This is an unnecessary burden to the
> LoadFunc writer and it is very error proning. This issue is to move this
> logic from LoadFunc to Pig core. LoadFunc.getSchema then only need to return
> original schema even after pruning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
