[
https://issues.apache.org/jira/browse/PIG-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852695#action_12852695
]
Hadoop QA commented on PIG-1346:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12440552/PIG-1346-2.patch
against trunk revision 930123.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/278/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/278/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/278/console
This message is automatically generated.
> In unit tests Util.executeShellCommand relies on java commands being in the
> path and does not consider JAVA_HOME
> ----------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1346
> URL: https://issues.apache.org/jira/browse/PIG-1346
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0, 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Attachments: PIG-1346-2.patch, PIG-1346.patch
>
>
> Util.executeShellCommand is currently used in unit tests to execute java
> related binaries like "java", "javac", "jar" - this method should check if
> JAVA_HOME is set and use $JAVA_HOME/bin/java etc. If JAVA_HOME is not set,
> the method can try and execute the command as-is.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
