[ 
https://issues.apache.org/jira/browse/PIG-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856118#action_12856118
 ] 

Pradeep Kamath commented on PIG-1370:
-------------------------------------

- In Expression.java the comment reads - "// Because this isn't actually used 
yet. " - Expression class is currently used in 
LoadMetadata.setPartitionFilter() - I agree though that we should mark this not 
stable - Evolving perhaps?
- In SortColInfo.java, I think we should not mark this public since this is 
used entirely inside Pig code and any communicating to external storeFuncs is 
through ResourceSchema. The same comment holds for SortInfo.java
- In EvalFunc.java minor typo - "* a fields " should be "* fields"
- Is there a way to mark public methods in a class as "internal" - for example 
PigServer.getAliases() - currently this is used by unit tests - should we be 
exposing this method to the
user? if not can we mark it not public through annotation? (Is there a 
different policy like if there is no javadoc comments for a public method, then 
it is not truely public?)
- In Accumulator.java minor typo - "This in intended" should be "This is 
intended"
- I think CollectableLoadFunc should be evolving
- ComparsionFunc.java unfortunately already had ctrl-m chars - the new 
additions in the patch also do - if it isn't extensive, we could remove the 
ctrl-m chars. Another comment is that per 
http://wiki.apache.org/pig/Pig070IncompatibleChanges, custom comparators are no 
longer supported since 0.7 - if so, should this be @deprecated? - I think 
currently custom comparators don't work in local mode.
- I hope marking LoadFunc stable will not prevent additions to this abstract 
class (which should not break backward compatibilty if default impls are 
provided)




> Marking Pig interfaces for org.apache.pig package
> -------------------------------------------------
>
>                 Key: PIG-1370
>                 URL: https://issues.apache.org/jira/browse/PIG-1370
>             Project: Pig
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>             Fix For: 0.8.0
>
>         Attachments: PIG-1370.patch
>
>
> Done as a separate JIRA from PIG-1311 since this alone contains quite a lot 
> of changes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to