[ 
https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866679#action_12866679
 ] 

Daniel Dai commented on PIG-566:
--------------------------------

Yes, you are right. This trick does not always work due to the rounding. But 
the original code seems no harm to try to do that. The bug in the original code 
is the negative case. As long as we address the negative case we fix the test 
failure. I don't think we should go beyond that in this patch. Also for the 
L/l, F/f suffix part, user can generate input data externally (not through 
TupleFormat), in this case, we still want to recognize these suffix. 

> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
>                 Key: PIG-566
>                 URL: https://issues.apache.org/jira/browse/PIG-566
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0, 0.8.0
>            Reporter: Santhosh Srinivasan
>            Assignee: Gianmarco De Francisci Morales
>            Priority: Minor
>             Fix For: 0.7.0, 0.8.0
>
>         Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, 
> PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to