[
https://issues.apache.org/jira/browse/PIG-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883029#action_12883029
]
Daniel Dai commented on PIG-1468:
---------------------------------
The problem is we do not have unsigned byte in Java. Although DataByteArray is
for semantic unknown type and the actual order does not matter, it is more
natural to see 0xff > 0x00. I have two comments:
1. Can we measure if there is any noticeable performance downgrade due to two
additional "and" operation?
2. Do we have somewhere else use this logic? It is important to keep them
consistent.
> DataByteArray.compareTo() does not compare in lexicographic order
> -----------------------------------------------------------------
>
> Key: PIG-1468
> URL: https://issues.apache.org/jira/browse/PIG-1468
> Project: Pig
> Issue Type: Bug
> Reporter: Gianmarco De Francisci Morales
> Assignee: Gianmarco De Francisci Morales
> Attachments: PIG-1468.patch
>
>
> The compareTo() method of org.apache.pig.data.DataByteArray does not compare
> items in lexicographic order.
> Actually, it takes into account the signum of the bytes that compose the
> DataByteArray.
> So, for example, 0xff compares to less than 0x00
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
