[
https://issues.apache.org/jira/browse/PIG-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899718#action_12899718
]
Jeff Zhang commented on PIG-1205:
---------------------------------
Several comments:
1. Is it possible to specify min_row_key and max_row_key in parameters, in the
current implementation, hbase will create split covering the whole table. But
sometimes we do not need to scan all the table. Some regions can been ignored.
This can improve the performance.
2. One small suggestion: move line 206 to if block (only one time setting is
enough)
{code}
if (scanFilter == null) {
scanFilter = new FilterList();
scan.setFilter(scanFilter);
}
{code}
3. It's better to add warning log in HBaseBinaryConverter when the bytes is cut
off for type conversion
4. The parameter "Per-region limit" is a bit confusing for me, I think users
would like to the set the limit on the whole table not per region. What do you
think ?
> Enhance HBaseStorage-- Make it support loading row key and implement StoreFunc
> ------------------------------------------------------------------------------
>
> Key: PIG-1205
> URL: https://issues.apache.org/jira/browse/PIG-1205
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.7.0
> Reporter: Jeff Zhang
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.8.0
>
> Attachments: PIG_1205.patch, PIG_1205_2.patch, PIG_1205_3.patch,
> PIG_1205_4.patch, PIG_1205_5.path
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
