[ 
https://issues.apache.org/jira/browse/PIG-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900107#action_12900107
 ] 

Olga Natkovich commented on PIG-1524:
-------------------------------------

+1 with a couple comment cleanups:

(1) Locking comment is misleading because we don't actually lock anything :)
(2) Comment regarding moving data from list to array for sorting needs to be 
also clarified.

Other than that, looks good. Please, commit

> 'Proactive spill count' is misleading
> -------------------------------------
>
>                 Key: PIG-1524
>                 URL: https://issues.apache.org/jira/browse/PIG-1524
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>             Fix For: 0.8.0
>
>         Attachments: PIG-1524.2.patch, PIG-1524.3.patch, PIG-1524.patch
>
>
> InternalCacheBag, InternalSortedBag, InternalDistinctBag increment this 
> counter for every record that it writes to disk, once it exceeds the memory 
> limit. This number is misleading.
> Instead, this counter should be increment it by 1 for each instance of these 
> bags that has spilled to disk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to