[ 
https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903123#action_12903123
 ] 

Alan Gates commented on PIG-1565:
---------------------------------

Comments
# ErrorCatchingBase swallows any non-ExecExceptions.  It should print their 
messages out as warnings.  Warnings are collated and the count reported at the 
end of the job.  Details are only printed if the user asks for them.  That way 
the user will still be informed that something unexpected happened and can 
investigate further if he wants to.
# On the duplication, it looks to me like INDEX_OF and LAST_INDEX_OF are 
supersets of the functions already in Pig.  You could submit a patch for those 
two functions (which are now builtins) to extend them to take the optional 
third argument.  SPLIT_ON_REGEX looks like a subset of the existing SPLIT 
function that is built into Pig, so other than having it as an alias so that 
Amazon users who are used to calling SPLIT_ON_REGEX I'm not clear what the 
value is.

Thanks for contributing all these, this is great.

I'll run test-patch and the unit tests and post the results.


> additional piggybank datetime and string UDFs
> ---------------------------------------------
>
>                 Key: PIG-1565
>                 URL: https://issues.apache.org/jira/browse/PIG-1565
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Andrew Hitchcock
>         Attachments: PIG-1565-1.patch
>
>
> Pig is missing a variety of UDFs that might be helpful for users implementing 
> Pig scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to